Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptional 0.H i18n update on 19 August 2024 #75835

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

kevingranade
Copy link
Member

@kevingranade kevingranade commented Aug 19, 2024

Summary

None

Purpose of change

We never hooked up the translation import-export workflows as of when we did the 0.H fork, so they're out of date in both directions.

Describe the solution

I manually ran the workflow steps from pull-translations.yml but with the transifex resource specified as 0.H and from the 0.H branch.

Describe alternatives you've considered

Leaving the strings even more out of date for release?

Testing

We really can't do anything except spot check some strings here and there? There's a ton of comment-header updates as well, so it's also super noisy.

Additional context

I also manually ran the update workflow to push the new string table (.pot) to the transifex resource for 0.H.
Translation file changes are intended.

Copy link
Contributor

It appears you modified a .po or .pot file. These translation files are automatically generated, pushed to, and pulled from Transifex, and should not be modified otherwise. If these changes are intended, please add Translation file changes are intended to the PR body.

@kevingranade
Copy link
Member Author

I manually scanned through the .fr diffs since that's the language I'm most nearly able to read.

The huuuge (about half a million) number of removed lines seems to be due to an overhaul of name handling, there were about 26,000 entries of this form:

-#. ~ Snippet in category "<random_male_first_name>"
-#. ~ Snippet in category "<random_female_first_name>"
-#. ~ Snippet in category "<bottom_name>"
-#. ~ Used to pick a random given name.  List taken from the top 500 most
-#. common names here: https://forebears.io/united-
-#. states/massachusetts/forenames
-#: data/json/snippets/names.json
-#: data/mods/MindOverMatter/snippets/snippets_random_names.json
-msgid "Maurice"
-msgstr ""

throughout all the .po files.

Other than that, I saw a large number of new translation strings, and a huge number of edits to existing strings that seem to be improvements, at least to my not-actually-literate eye.

There might be a big block of newspaper snippet removals as well, though it's hard to tell because they were all scrambled up with the name removals.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 19, 2024
@dseguin dseguin merged commit b356ae3 into 0.H-branch Aug 20, 2024
13 of 22 checks passed
@kevingranade kevingranade deleted the 0.H-translations-update branch August 22, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants