Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash when no proficiencies in character menu #75370

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

Roguecop
Copy link
Contributor

@Roguecop Roguecop commented Aug 1, 2024

Summary

Bugfixes "Avoid crash when the character has no proficiencies and we press enter on them inside Character menu "@"

Purpose of change

Yesterday I wanted to play a bit with a new random character. This character had no skills, and when I was looking inside the Character menu, I clicked enter and crashed the game.

Describe the solution

Minor change in the code to solve the problem

Testing

  • Created a new character without proficiencies. Without crash in the character menu
  • Add some proficiencies and click again. Works as expected

Additional context

Crash

crash_proficiencies.mp4

Avoid crash when no proficiencies in character menu and we press enter over proficiencies
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions labels Aug 1, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Aug 1, 2024
@Roguecop
Copy link
Contributor Author

Roguecop commented Aug 1, 2024

As far as I know, this should not be giving an error in testing. Can anyone understand what is going on to create the error?

image

image

Here is the log of a complete test execution in my machine, where only I fail the same test as could fail executing a test from master

test.log

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 2, 2024
@Maleclypse
Copy link
Member

Basic build is passed for you but I've gone ahead and kicked some of the canceled tests to see if anything relevant pops up. I'm expecting this will merge sometime after those go through and what you were asking about was a random failure unrelated to your changes.

@dseguin dseguin merged commit 874dded into CleverRaven:master Aug 4, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants