Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better debugmsg of multiple attacks of the same type #75364

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Aug 1, 2024

Summary

None

Purpose of change

There are zero reasons the game should not mention that your multiple attacks of the same type are erased to one, especially when we show this information when running CI

Describe the solution

Remove test_mode check, explain how to resolve the error

Testing

CI

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 1, 2024
@dseguin dseguin merged commit b32dd2b into CleverRaven:master Aug 2, 2024
24 of 29 checks passed
@GuardianDll GuardianDll deleted the better_monattack_msg branch August 2, 2024 18:43
@GuardianDll GuardianDll added the 0.H Backport PR to backport to the 0.H stable release canddiate label Aug 14, 2024
GuardianDll added a commit that referenced this pull request Aug 19, 2024
@GuardianDll GuardianDll mentioned this pull request Aug 19, 2024
@GuardianDll GuardianDll added 0.H Backported and removed 0.H Backport PR to backport to the 0.H stable release canddiate labels Aug 19, 2024
kevingranade pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants