Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Mortar Recipe's cement recipe book requirement #75348

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

VileReviled
Copy link
Contributor

Summary

Balance "Mortar is now an autolearned recipe"

Purpose of change

Fixes #74015.

Describe the solution

Makes Mortar into an autolearned recipe, and removes book requirement.

Describe alternatives you've considered

As many commenters in #74015 agree, simply making this into an autolearned recipe is a little pathetic. I'd love to revisit this once I have more experience

Testing

Linting produced no errors I can tell. I can't test through Docker currently; testing welcome!!!

Additional context

This is my first PR! Feedback appreciated

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bugfix> This is a fix for a bug (or closes open issue) Game: Balance Balancing of (existing) in-game features. new contributor astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 31, 2024
@Maleclypse
Copy link
Member

{
    "id": "bag_durasack_cement",
    "type": "GENERIC",
    "category": "container",
    "name": { "str": "durable plastic sack, cement" },
    "looks_like": "bag_plastic",
    "description": "A large and sturdy sack, made out plastic material.  Stores cement and has instructions on how to use it to make mortar.",
    "//": "durasack woven polypropylene bags",
    "copy-from": "bag_durasack",
    "use_action": {
      "type": "effect_on_conditions",
      "description": "Instructions on what to do with the contents of the bag.",
      "effect_on_conditions": [ "EOC_CEMENT_INSTRUCTIONS" ]
    }
  },
  {
    "type": "effect_on_condition",
    "id": "EOC_CEMENT_INSTRUCTIONS",
    "condition": { "and": [ { "u_has_trait": "ILLITERATE" }, { "not": "u_driving" } ] },
    "effect": [
      { "u_learn_recipe": "mortar_build" }
    ]
  },

This would be an ideal way to resolve this. If you want me to I can update your PR with this and fix the itemgroups that would need updating as well.

@VileReviled
Copy link
Contributor Author

This would be an ideal way to resolve this. If you want me to I can update your PR with this and fix the itemgroups that would need updating as well.

Yes please! I agree that this is ideal.

@Maleclypse
Copy link
Member

I really appreciate you putting a PR together for this. Thank you for doing this and I hope to see you contribute some more :)

@github-actions github-actions bot added Spawn Creatures, items, vehicles, locations appearing on map Items: Containers Things that hold other things labels Aug 1, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Aug 1, 2024
shortens 3 lines to one line

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 1, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 1, 2024
@Maleclypse Maleclypse merged commit 99386ed into CleverRaven:master Aug 2, 2024
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mortar recipe is too hard to get
2 participants