Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AFS/MoM] Fix concentration proficiency leveling EoC #75229

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jul 25, 2024

Summary

Bugfixes "[AFS/MoM] Fix concentration proficiency leveling EoC"

Purpose of change

MoM and AFS had the same concentration proficiency check IDs, which meant that the later-loaded one takes precedence. If you have Aftershock after MoM, the proficiencies look for AFS powers, making it impossible to use MoM to level them.

Fixes #75224

Describe the solution

Describe alternatives you've considered

Add AFS into the Aftershock proficiency EoC IDs.

Testing

Now possible to level concentration proficiencies on the provided save.

Additional context

Reminding me I need to do some Aftershock maintenance porting over some MoM changes and also add the Geist profession (telekinetic).

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod EOC: Effects On Condition Anything concerning Effects On Condition labels Jul 25, 2024
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 25, 2024
@Maleclypse Maleclypse merged commit 8002d98 into CleverRaven:master Jul 26, 2024
28 of 30 checks passed
@Standing-Storm Standing-Storm deleted the afs-conc-rename branch July 26, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MoM] Concentration proficiency didn't train
2 participants