Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curable Shakes & Opium Sates #75218

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Conversation

Consoleable
Copy link
Contributor

@Consoleable Consoleable commented Jul 24, 2024

Summary

Balance "Opiate shakes caused by cravings go away after taking opiates. Other shakes are unaffected."

Purpose of change

Opiate addictions could easily generate shakes that lasted for over an hour even if you immediately take strong opiates.
Now, when it checks to see if you've satisfied your craving, and you have, it will remove the shakes. Also, satisfaction is determined by addiction intensity, rather than a static number. Addiction intensity growth is now more important, as satisfying opiate addiction will increase it, making it harder to satisfy.

Describe the solution

added line to remove shakes when addiction is satisfied. changed satisfaction threshhold to reflect addiction intensity(which still goes up with drug use)

Describe alternatives you've considered

overhauling addictions in general, which i'll still probably do after other projects.

Testing

tested in basic build, seems to work with test char.|
retested with addiction(30) vs tramadol and found it was not enough to satisfy, as intended. TY for Venera's catch.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions labels Jul 24, 2024
made satisfaction based on addiction intensity
@Consoleable Consoleable changed the title Curable shakes Curable shakes & Opium Sates Jul 24, 2024
@Consoleable Consoleable changed the title Curable shakes & Opium Sates Curable Shakes & Opium Sates Jul 24, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jul 24, 2024
@Consoleable Consoleable marked this pull request as ready for review July 24, 2024 23:20
@Venera3
Copy link
Member

Venera3 commented Jul 25, 2024

The addiction intensity won't scale above 20 the way that's set up, letting you get away with way less to satisfy your cravings.

@Consoleable
Copy link
Contributor Author

Consoleable commented Jul 25, 2024

The addiction intensity won't scale above 20 the way that's set up, letting you get away with way less to satisfy your cravings.

Right you are, I doublechecked and it looks like 'in' uses min(20,intensity) rather than max(~) like i had assumed.
Will fix before merge.

edit: Have fixed, tested, seems to work as intended now. Thanks!

changed satisfaction requirement from 'in' to addiction instensity
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 25, 2024
@Maleclypse Maleclypse merged commit b0aae89 into CleverRaven:master Jul 25, 2024
27 checks passed
@Consoleable Consoleable deleted the curable-shakes branch July 25, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants