Update construction.cpp

[thefancyyeller]

Summary

Interface "Construction menu filter resets on close"

Purpose of change

When you have a filter in the crafting menu it resets on close. When you have a filter in the construction menu it is maintained and the user has to backspace their filter. This is a UI inconsistency that messes with muscle memory.

Describe the solution

I only added 1 line so that the filter is reset when the UI menu is instanced.

Describe alternatives you've considered

An alternative would be to maintain this behavior in the crafting menu along with the ability to press the 'del' key to backspace all of the characters at once.

Testing

In the game I loaded in, opened the construction menu, and it resets the filter on open as expected.

[PatrikLundell]

Does it open on the last selected entry? If it does, that's probably OK, but if it doesn't so you'd have to enter the filter again to find the entry again it's not.

Also note that there are some filters that are retained and some that are reset, so consistency is a poor argument (and there are probably more that are retained than the number reset). A much better argument would be to explain why resetting is better than retaining for this UI.

[thefancyyeller]

@PatrikLundell It does stay on the last used section of the UI, because typically you access one section repeatedly in a given task. The text bar should be reset, in my opinion, because in my experience "deconstruct X to construct Y" is a very very common thing to do in game and when I have to individually backspace every character from "deconstruct" and for whatever reason backspacing is quite slow in the UI.

In the particular case of the filter bar, due to the amount of keystrokes it takes to manually backspace, I believe clearing it like we do with crafting is appropriate.

Also on the topic of consistence, crafting and construction are near the top in terms of things you do frequently in the game, therefore I think they should be consistent with each other. It is a case of muscle-memory.

EDIT: I misread your question, I will check right now if it stays on the last entry.

[thefancyyeller]

It does not stay on the previously done crafting element it resets entirely. I can work on trying to make that happen.

[akrieger]

Can you retitle the PR/commit message to be more descriptive :) ?