Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ar-15 .22 conversion kit #75210

Merged
merged 8 commits into from
Jul 29, 2024
Merged

add ar-15 .22 conversion kit #75210

merged 8 commits into from
Jul 29, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

ar-15 is funky, and multiple brands offers the kits to convert it into .22 round. why not?

Describe the solution

Add a conversion kit, with 10 and 28 round mags offered (stats delivered from chiappa production)

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Items: Magazines Ammo holding items and objects. Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Spawn Creatures, items, vehicles, locations appearing on map Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 24, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • This is a complete upper receiver assembly containing a barrel, handguard, and bolt carrier group that, given the right knowledge, is installable upon an AR-15-style rifle's lower frame. Swappable uppers enable compatible firearms to be retooled for different cartridges and barrel lengths, with this kit furnishing a weapon with a 16-inch barrel chambered for .22 rounds. Specialized or modified STANAG-style magazines are required to properly feed cartridges of a differe.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Hyperseeker
Copy link
Contributor

The M4-22 might not be the best choice unless you're decidedly making the .22LR conversion dangerous:

Huge wall of text so tl;dr, my Chiappa M4-22 Gen II with ~4500 rounds through it had a catastrophic failure that resulted in the upper falling to pieces in my hand during a routine cleaning.

The PSA upper might be a better choice. The reviews aren't exceptional, but the primary complaint is a lack of compatibility with some lowers, which the game doesn't model.

@GuardianDll
Copy link
Member Author

I don't think we need to unabstract conversions in order to emulate possible malfunctions of a gun (that we don't have anyway)

Besides, i don't think a report of a single user should be applied to entire line of a product - i suspect there is enough of examples of catastrophic failures in all possible conversions, guns and whatnot

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 25, 2024
data/json/items/magazine/22.json Outdated Show resolved Hide resolved
data/json/items/magazine/22.json Outdated Show resolved Hide resolved
@harakka
Copy link
Member

harakka commented Jul 25, 2024

The M4-22 might not be the best choice unless you're decidedly making the .22LR conversion dangerous

This is not meant to be that specific item, the stats are just taken from there. It stands in for AR .22lr kits in general, just like we don't have other brand+model kits.

@GuardianDll GuardianDll marked this pull request as draft July 25, 2024 17:04
@GuardianDll GuardianDll marked this pull request as ready for review July 25, 2024 17:10
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 25, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 28, 2024
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs labels Jul 28, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 29, 2024
@Maleclypse Maleclypse merged commit 951b8da into CleverRaven:master Jul 29, 2024
25 checks passed
@GuardianDll GuardianDll deleted the ar-22 branch July 29, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Generic Guns Anything to do with Generic Guns Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants