Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing <string> for std::string #75202

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

akrieger
Copy link
Member

@akrieger akrieger commented Jul 24, 2024

Summary

None

Purpose of change

MSVC does not transitively include <string> from <string_view>, or anything else included here. But a couple lines down something references std::string. So we need to include <string>.

Describe the solution

#include <string>

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 24, 2024
@Maleclypse Maleclypse merged commit f50d357 into CleverRaven:master Jul 24, 2024
23 of 30 checks passed
@akrieger akrieger deleted the string_me_up_scotty branch July 25, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants