Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Add Fulgurating Strikes Sylph trait #75198

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jul 23, 2024

Summary

Mods "[Xedra Evolved] Add Fulgurating Strikes Sylph trait"

Purpose of change

Sylphs don't have a trait that makes lightning explode everywhere while they fight. I feel like that needs to change

Describe the solution

Add Fulgurating Strikes, a trait that adds an electrical charge to the Sylph's attacks. Each attack costs mana while the trait is active.

If the Sylph knows the more powerful lightning spells, then the attack also blasts electric fields around them when they attack.

Describe alternatives you've considered

Testing

Trait exists, lightning damage applies on melee attacks, with enough magical knowledge, there are bursts of lightning fields too. Each attack costs mana. If you run out of mana, the trait turns off.

Additional context

@Standing-Storm Standing-Storm changed the title [Xedra Evolved] Add Fulgurating Strikes Slyph trait [Xedra Evolved] Add Fulgurating Strikes Sylph trait Jul 23, 2024
@github-actions github-actions bot requested a review from Maleclypse July 23, 2024 20:36
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jul 23, 2024
@Standing-Storm Standing-Storm marked this pull request as draft July 23, 2024 20:36
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 23, 2024
@github-actions github-actions bot added EOC: Effects On Condition Anything concerning Effects On Condition and removed json-styled JSON lint passed, label assigned by github actions labels Jul 23, 2024
@github-actions github-actions bot added the Mechanics: Enchantments / Spells Enchantments and spells label Jul 23, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Fulminaitng Strikes Lightning Fields

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Standing-Storm Standing-Storm marked this pull request as ready for review July 24, 2024 01:42
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 24, 2024
@Maleclypse Maleclypse merged commit 8ffc091 into CleverRaven:master Jul 24, 2024
24 checks passed
@Standing-Storm Standing-Storm deleted the patch-1 branch July 25, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants