Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify temperature conversion function usage #1326

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Just make it a function on the temperature type enum.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (10a37c2) 31.57% compared to head (49c1604) 31.68%.

Files Patch % Lines
src/app/data_harvester/temperature/linux.rs 0.00% 4 Missing ⚠️
src/app/data_harvester/nvidia.rs 0.00% 2 Missing ⚠️
src/app/data_harvester/temperature.rs 95.23% 1 Missing ⚠️
src/app/data_harvester/temperature/sysinfo.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
+ Coverage   31.57%   31.68%   +0.11%     
==========================================
  Files          97       97              
  Lines       16943    16953      +10     
==========================================
+ Hits         5349     5372      +23     
+ Misses      11594    11581      -13     
Flag Coverage Δ
macos-12 33.45% <83.33%> (+0.12%) ⬆️
ubuntu-latest 33.26% <74.07%> (+0.11%) ⬆️
windows-2019 33.49% <83.33%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Just make it a function on the temperature type enum.
@ClementTsang ClementTsang force-pushed the simplify_temp_conversion branch from 83010cd to be93068 Compare November 20, 2023 07:47
@ClementTsang ClementTsang force-pushed the simplify_temp_conversion branch from be93068 to 9d69825 Compare November 20, 2023 07:47
@ClementTsang ClementTsang merged commit ab93311 into master Nov 20, 2023
33 checks passed
@ClementTsang ClementTsang deleted the simplify_temp_conversion branch November 20, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant