Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill footnotes like '{N:001}' #91

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Kill footnotes like '{N:001}' #91

merged 1 commit into from
Jun 14, 2024

Conversation

jonathanrobie
Copy link
Contributor

@jonathanrobie jonathanrobie commented Jun 12, 2024

In each directory, I searched for footnote ids like this:

grep -rl '{N:001}' .

Then I replaced them with sed (using xargs):

grep -rl '{N:001}' . | xargs sed -i 's/{N:001}//g'

I also searched for N:002, but didn't find any.

@jcuenod
Copy link

jcuenod commented Jun 13, 2024

Looks like only 12.[5-9] include this footnote

@rdeblois1960
Copy link

rdeblois1960 commented Jun 13, 2024 via email

@jonathanrobie
Copy link
Contributor Author

jonathanrobie commented Jun 13, 2024

Do you have another way to mark footnote callers? Reinier

Should footnote callers be invoked from these attributes in the Macula trees and TSVs? @RickBrannan ?

@jonathanrobie
Copy link
Contributor Author

Looks like only 12.[5-9] include this footnote

Yes, I think that's right.

@RickBrannan
Copy link
Contributor

Should footnote callers be invoked from these attributes in the Macula trees and TSVs? @RickBrannan ?

I don't think that Macula trees/TSVs should include the callers to the notes.

Copy link
Contributor

@RickBrannan RickBrannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that removing the {N:\d+} notation is appropriate for inclusion of the data in Macula. The lexicon itself should include and utilize such data, but I don't think it necessary for Macula.

@RickBrannan RickBrannan merged commit b5b7ece into main Jun 14, 2024
1 check passed
@RickBrannan RickBrannan deleted the kill-footnotes branch June 14, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants