Use after and remove brackets

[ryderwishart]

Closes #20
Closes #38
Closes Clear-Bible/macula-hebrew#24

[jonathanrobie]

I suspect punctuation should be removed from the @unicode attribute, no?

[ryderwishart]

I suspect punctuation should be removed from the @unicode attribute, no?

Well I don't actually know where that attribute came from, so I figured it should be an upstream fix, at least in the Nodes trees, rather than patching it up after the fact in the lowfat data, particularly since we don't use the @unicode content for any of our frontend applications of lowfat at this point.

[jonathanrobie]

Well I don't actually know where that attribute came from ...

Hmmm, Lowfat didn't used to have it at all. I think it may be the same as the content of the element. Could you please check to see if it ever differs from element content?

[jonathanrobie]

Please merge this as is, without worrying about @unicode, and we can worry about that next.

[themikejr]

Is the after attribute now doing two things for us?

1. Provides information a user needs to render sentences made of graphical words (i.e. when to combine word parts and when not to)
2. Provides information a user needs to properly render punctuation in sentences

[jonathanrobie]

Is the after attribute now doing two things for us?

1. Provides information a user needs to render sentences made of graphical words (i.e. when to combine word parts and when not to)

2. Provides information a user needs to properly render punctuation in sentences

The @after attribute does #2, rendering punctuation.

For word parts in Hebrew, use the numbering system, which identifies morphs within a graphical word.

[themikejr]

Is the after attribute now doing two things for us?

1. Provides information a user needs to render sentences made of graphical words (i.e. when to combine word parts and when not to)

2. Provides information a user needs to properly render punctuation in sentences

The @after attribute does #2, rendering punctuation.

For word parts in Hebrew, use the numbering system, which identifies morphs within a graphical word.

@jonathanrobie There are currently several instances in hebrew lowfat where the value of after is an empty space. I've been using this to create graphical words. Is this going away? Am I misusing it?

[jonathanrobie]

@jonathanrobie There are currently several instances in hebrew lowfat where the value of after is an empty space. I've been using this to create graphical words. Is this going away? Am I misusing it?

You can use @after for graphical words. That's not going away. The absence of an @after attribute means that there's nothing you need to put between this item and the next.