Merge pull request #93 from Clear-Bible/rnd-26-add-additional-unit-te…

…sts-for-error-element

Add tests with xfail for tracking presence of error elements

test/__init__.py

@@ -51,6 +51,8 @@
 tsv_path = "../Nestle1904/tsv/macula-greek-Nestle1904.tsv"
 __tsv_files__ = [tsv_path]
 
+ERROR_EXPRESSION = "//*[starts-with(local-name(), 'error') or starts-with(local-name(), 'error_')]"
+
 with open(tsv_path, encoding='utf-8') as file:
     reader = csv.DictReader(file, delimiter="\t")
     for row in reader:

test/test_nestle1904_lowfat.py

@@ -3,7 +3,7 @@
 import codecs
 import re
 from lxml import etree
-from test import __lowfat_files__, run_xpath_for_file
+from test import ERROR_EXPRESSION, __lowfat_files__, run_xpath_for_file
 
 
 @pytest.mark.parametrize("lowfat_file", __lowfat_files__)
@@ -73,6 +73,16 @@ def test_number_of_words():
         total_count += len(count)
     assert total_count == 137779
 
+
+# Expected failure.
+# See: https://github.com/Clear-Bible/macula-greek/issues/92#issuecomment-2407973591
+@pytest.mark.xfail
+@pytest.mark.parametrize("lowfat_file", __lowfat_files__)
+def test_no_errors(lowfat_file):
+    count = len(run_xpath_for_file(ERROR_EXPRESSION, lowfat_file))
+    assert count == 0
+
+
 @pytest.mark.parametrize("lowfat_file", __lowfat_files__)
 def test_referent_id_validity(lowfat_file):
     valid_ids = []

test/test_sblgnt_lowfat.py

@@ -3,7 +3,7 @@
 import codecs
 import re
 from lxml import etree
-from test import __sblgnt_lowfat_files__, run_xpath_for_file
+from test import ERROR_EXPRESSION, __sblgnt_lowfat_files__, run_xpath_for_file
 
 
 @pytest.mark.parametrize("lowfat_file", __sblgnt_lowfat_files__)
@@ -76,6 +76,16 @@ def test_number_of_words():
         total_count += len(count)
     assert total_count == 137741
 
+
+# Expected failure.
+# See: https://github.com/Clear-Bible/macula-greek/issues/92#issuecomment-2407973591
+@pytest.mark.xfail
+@pytest.mark.parametrize("lowfat_file", __sblgnt_lowfat_files__)
+def test_no_errors(lowfat_file):
+    count = len(run_xpath_for_file(ERROR_EXPRESSION, lowfat_file))
+    assert count == 0
+
+
 # TODO: Discuss with team and restore this test
 # @pytest.mark.parametrize("lowfat_file", __sblgnt_lowfat_files__)
 # def test_referent_id_validity(lowfat_file):