Merge pull request #31 from Cjewett/feature/update_german_translations

quick fix for german translations and chat message output
Cjewett · Jan 11, 2020 · 3df7907 · 3df7907
2 parents c2bccdb + ab10c2c
commit 3df7907
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/HonorAssist.toc b/HonorAssist.toc
@@ -1,7 +1,7 @@
 ## Interface: 11303
 ## Title: HonorAssist
 ## Author: Eulav, CptMerlot
-## Version: 0.9.3
+## Version: 0.9.4
 ## SavedVariablesPerCharacter: HonorAssistData, HonorAssistLogging, HonorAssistTrackerFramePositionX, HonorAssistTrackerFramePositionY, HonorAssistShowTrackerUi, HonorAssistNameplateToggle, HonorAssistShortKillMessageToggle, HonorAssistBattlegroundFramesPositionX, HonorAssistBattlegroundFramesPositionY, HonorAssistBattlegroundFramesToggle, HonorAssistBattlegroundFramesLockToggle
 
 # Localization

diff --git a/HonorAssistChatMessage.lua b/HonorAssistChatMessage.lua
@@ -44,9 +44,15 @@ function HonorAssist:CreateHonorableKillMessage(estimatedHonorGained, playerKill
 	local chatInfo = ChatTypeInfo["COMBAT_HONOR_GAIN"]
 
 	if not HonorAssistShortKillMessageToggle then
-		text = HonorAssist:GetTranslation("YOU_HAVE_KILLED") .. ' ' .. playerKilled .. ' (' .. playerRank .. ') ' .. timesKilled .. ' ' .. HonorAssist:GetTranslation(timeText) .. '. '
-			.. HonorAssist:GetTranslation("THIS_KILL_GRANTED") .. ' ' .. percentage * 100 .. '% ' .. HonorAssist:GetTranslation("VALUE_FOR") .. ' |cFF00ccff' .. realisticHonor .. ' ' 
-			.. HonorAssist:GetTranslation("HONOR"):lower() .. '|cFF' .. HonorAssist:RGBPercToHex(chatInfo.r, chatInfo.g, chatInfo.b) .. ' ' .. string.match(text, "(%(.+)") .. '.'
+		if (GetLocale() == "deDE") then
+			text = HonorAssist:GetTranslation("YOU_HAVE_KILLED") .. ' ' .. playerKilled .. ' (' .. playerRank .. ') ' .. timesKilled .. ' ' .. HonorAssist:GetTranslation(timeText) .. '. '
+				.. HonorAssist:GetTranslation("THIS_KILL_GRANTED") .. ' ' .. percentage * 100 .. '% ' .. HonorAssist:GetTranslation("VALUE_FOR") .. ' |cFF00ccff' .. realisticHonor .. ' ' 
+				.. HonorAssist:GetTranslation("HONOR") .. '|cFF' .. HonorAssist:RGBPercToHex(chatInfo.r, chatInfo.g, chatInfo.b) .. ' ' .. string.match(text, "(%(.+)") .. '.'
+		else
+			text = HonorAssist:GetTranslation("YOU_HAVE_KILLED") .. ' ' .. playerKilled .. ' (' .. playerRank .. ') ' .. timesKilled .. ' ' .. HonorAssist:GetTranslation(timeText) .. '. '
+				.. HonorAssist:GetTranslation("THIS_KILL_GRANTED") .. ' ' .. percentage * 100 .. '% ' .. HonorAssist:GetTranslation("VALUE_FOR") .. ' |cFF00ccff' .. realisticHonor .. ' ' 
+				.. HonorAssist:GetTranslation("HONOR"):lower() .. '|cFF' .. HonorAssist:RGBPercToHex(chatInfo.r, chatInfo.g, chatInfo.b) .. ' ' .. string.match(text, "(%(.+)") .. '.'
+		end
 	else
 		text = playerKilled .. ' (' .. playerRank .. ') ' .. timesKilled .. 'x: |cFF00ccff' .. realisticHonor .. ' ' .. HonorAssist:GetTranslation("HONOR"):lower()
 	end

diff --git a/Localizations/deDE.lua b/Localizations/deDE.lua
@@ -12,12 +12,12 @@ local L = {
 	["KILLS"] = "Siege";
 	["DAILY"] = "Täglich";
 	["HOUR"] = "Stunde";
-	["HONOR_ASSIST"] = "Honour Assist";
-	["YOU_HAVE_KILLED"] = "Du hast getötet";
-	["TIME"] = "zeit";
-	["TIMES"] = "mal";
-	["THIS_KILL_GRANTED"] = "Dieser Mord wurde gewährt";
-	["VALUE_FOR"] = "wert für";
+	["HONOR_ASSIST"] = "Honor Assist";
+	["YOU_HAVE_KILLED"] = "Du hast";
+	["TIME"] = "mal getötet";
+	["TIMES"] = "mal getötet";
+	["THIS_KILL_GRANTED"] = "Dieser Mord gab";
+	["VALUE_FOR"] = "für";
 	["THIS_WEEK"] = "Diese Woche";
 	["HISTORY"] = "Geschichte";
 	["FROM_BONUS"] = "From Bonus";