Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub workflow updates #757

Merged
merged 3 commits into from
Jun 3, 2024
Merged

GitHub workflow updates #757

merged 3 commits into from
Jun 3, 2024

Conversation

dmundra
Copy link
Contributor

@dmundra dmundra commented May 31, 2024

Moved the github workflow changes from #755 to here to keep them separate.

I enabled in the settings the update branch requirement and also requirement that pa11y and cypress tests are passing:

Screenshot of settings

Because of that I added the auto update from guidebook and also dropped a11ywatch as it is not as useful as pa11y right now.

@dmundra dmundra requested a review from mgifford May 31, 2024 14:48
@dmundra dmundra self-assigned this May 31, 2024
Copy link

Cypress Test Results

12 tests   12 ✔️  46s ⏱️
11 suites    0 💤
  5 files      0

Results for commit 68c517d.

@dmundra dmundra marked this pull request as ready for review May 31, 2024 14:52
Copy link

Pa11y testing results
> pa11y-ci:sitemap
> pa11y-ci --sitemap http://127.0.0.1:4000/sitemap.xml --sitemap-find https://accessibility.civicactions.com --sitemap-replace http://127.0.0.1:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 127 URLs:
 > http://localhost:4000/guide/champions-program - 0 errors
 > http://localhost:4000/guide/design - 0 errors
 > http://localhost:4000/guide/documents - 0 errors
 > http://localhost:4000/guide/events - 0 errors
 > http://localhost:4000/guide/glossary - 0 errors
 > http://localhost:4000/guide/history - 0 errors
 > http://localhost:4000/guide/identity-language - 0 errors
 > http://localhost:4000/guide/introduction - 0 errors
 > http://localhost:4000/guide/onboarding-staff - 0 errors
 > http://localhost:4000/guide/organizations - 0 errors
 > http://localhost:4000/guide/plain-language - 0 errors
 > http://localhost:4000/guide/resources - 0 errors
 > http://localhost:4000/guide/semantic-html - 0 errors
 > http://localhost:4000/guide/social-media - 0 errors
 > http://localhost:4000/guide/tools - 0 errors
 > http://localhost:4000/guide/training - 0 errors
 > http://localhost:4000/about/people/allison-carroll - 0 errors
 > http://localhost:4000/about/people/civicactions - 0 errors
 > http://localhost:4000/about/people/daniel-mundra - 0 errors
 > http://localhost:4000/about/people/jack-haas - 0 errors
 > http://localhost:4000/about/people/jennifer-houde - 0 errors
 > http://localhost:4000/about/people/jonathan-bourland - 0 errors
 > http://localhost:4000/about/people/luke-fretwell - 0 errors
 > http://localhost:4000/about/people/michelle-kang - 0 errors
 > http://localhost:4000/about/people/mike-gifford - 0 errors
 > http://localhost:4000/about/people/nira-datta - 0 errors
 > http://localhost:4000/about/people/vanessa-luxen - 0 errors
 > http://localhost:4000/personas/accessibility-avery - 0 errors
 > http://localhost:4000/personas/designer-darcy - 0 errors
 > http://localhost:4000/personas/engineer-emery - 0 errors
 > http://localhost:4000/personas/procurement-parker - 0 errors
 > http://localhost:4000/personas/qa-quincy - 0 errors
 > http://localhost:4000/personas/remote-raz - 0 errors
 > http://localhost:4000/playbook/AT - 0 errors
 > http://localhost:4000/playbook/ai-and-ia - 0 errors
 > http://localhost:4000/playbook/authoring - 0 errors
 > http://localhost:4000/playbook/automated-testing - 0 errors
 > http://localhost:4000/playbook/checklists - 0 errors
 > http://localhost:4000/playbook/community - 0 errors
 > http://localhost:4000/playbook/distributed-teams - 0 errors
 > http://localhost:4000/playbook/documents - 0 errors
 > http://localhost:4000/playbook/follow-global-initiatives - 0 errors
 > http://localhost:4000/playbook/manual-testing - 0 errors
 > http://localhost:4000/playbook/personalization - 0 errors
 > http://localhost:4000/playbook/practice - 0 errors
 > http://localhost:4000/playbook/pwd - 0 errors
 > http://localhost:4000/playbook/roles - 0 errors
 > http://localhost:4000/playbook/statements - 0 errors
 > http://localhost:4000/playbook/training - 0 errors
 > http://localhost:4000/posts/4-ways-to-improve-government-accessibility-through-open-source - 0 errors
 > http://localhost:4000/posts/hello-world - 0 errors
 > http://localhost:4000/posts/whitehouse.gov-beginning-an-accessibility-journey - 0 errors
 > http://localhost:4000/posts/gcn-accessibility-compliance-as-code - 0 errors
 > http://localhost:4000/posts/improve-government-accessibility-through-open-source - 0 errors
 > http://localhost:4000/posts/govtech-how-will-biden-transform-government-website-accessibility - 0 errors
 > http://localhost:4000/posts/automated-accessibility-testing-leveraging-github-actions-and-pa11y-ci-with-axe - 0 errors
 > http://localhost:4000/posts/government-accessibility-and-the-cms-problem - 0 errors
 > http://localhost:4000/posts/at-banter-podcast - 0 errors
 > http://localhost:4000/posts/mvp-playbook - 0 errors
 > http://localhost:4000/posts/mvp-guide - 0 errors
 > http://localhost:4000/posts/smashingmag-baking-in-accessibility-testing - 0 errors
 > http://localhost:4000/posts/qa-with-mike-gifford-accessibility-in-civic-tech - 0 errors
 > http://localhost:4000/posts/launching-a-community-of-practice-for-accessibility-in-government-services - 0 errors
 > http://localhost:4000/posts/pre-GAAD-Authoring-Tools-Built-in-Accessibility - 0 errors
 > http://localhost:4000/posts/website-analytics - 0 errors
 > http://localhost:4000/posts/how-we-scale-inclusive-website-content-with-automated-testing-and-open-source-tools - 0 errors
 > http://localhost:4000/posts/social-media-accessibility-guide - 0 errors
 > http://localhost:4000/posts/plain-language-accessibility-guide - 0 errors
 > http://localhost:4000/posts/heart-accessibility - 0 errors
 > http://localhost:4000/posts/scanning-over-two-million-gov-pages - 0 errors
 > http://localhost:4000/posts/gsa-machine-readable-acr - 0 errors
 > http://localhost:4000/posts/CivicActions-Creates-Open-Product-Accessibility-Template - 0 errors
 > http://localhost:4000/posts/how-drupal-helps-us-bake-accessibility-into-every-project - 0 errors
 > http://localhost:4000/posts/CivicActions-Accessibility-Pledge - 0 errors
 > http://localhost:4000/posts/Talking-Drupal-Podcast - 0 errors
 > http://localhost:4000/posts/Talking-Drupal-Podcast-382 - 0 errors
 > http://localhost:4000/posts/governments-accessibility-opensource - 0 errors
 > http://localhost:4000/posts/FOSDEM-ccessibility-OpenSource - 0 errors
 > http://localhost:4000/posts/opensource-automated-accessibility-testing - 0 errors
 > http://localhost:4000/posts/helping-disabled-veterans-check-in-designing-an-accessibility-map - 0 errors
 > http://localhost:4000/posts/daniel-mundra-diving-into-drupal - 0 errors
 > http://localhost:4000/posts/how-omb-can-improve-gov-accessibility - 0 errors
 > http://localhost:4000/posts/fix-accessibility-bugs - 0 errors
 > http://localhost:4000/posts/five-reasons-to-get-excited-about-governmentwide-section-508-assessment-criteria - 0 errors
 > http://localhost:4000/projects/drupal - 0 errors
 > http://localhost:4000/projects/uswds-color - 0 errors
 > http://localhost:4000/projects/uswds - 0 errors
 > http://localhost:4000/roles/content-designer - 0 errors
 > http://localhost:4000/roles/developer - 0 errors
 > http://localhost:4000/roles/executive - 0 errors
 > http://localhost:4000/roles/operations - 0 errors
 > http://localhost:4000/roles/procurement - 0 errors
 > http://localhost:4000/roles/product-manager - 0 errors
 > http://localhost:4000/roles/project-manager - 0 errors
 > http://localhost:4000/roles/ux-designer - 0 errors
 > http://localhost:4000/topics/design - 0 errors
 > http://localhost:4000/topics/disability-type - 0 errors
 > http://localhost:4000/topics/process-policies - 0 errors
 > http://localhost:4000/topics/roles - 0 errors
 > http://localhost:4000/topics/testing - 0 errors
 > http://localhost:4000/topics/tools - 0 errors
 > http://localhost:4000/about/ - 0 errors
 > http://localhost:4000/accessibility - 0 errors
 > http://localhost:4000/agile - 0 errors
 > http://localhost:4000/analytics - 0 errors
 > http://localhost:4000/calendar - 0 errors
 > http://localhost:4000/colophon - 0 errors
 > http://localhost:4000/conduct - 0 errors
 > http://localhost:4000/about/contact - 0 errors
 > http://localhost:4000/guide/ - 0 errors
 > http://localhost:4000/heart - 0 errors
 > http://localhost:4000/help - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/news/ - 0 errors
 > http://localhost:4000/about/join - 0 errors
 > http://localhost:4000/license - 0 errors
 > http://localhost:4000/okrs - 0 errors
 > http://localhost:4000/open - 0 errors
 > http://localhost:4000/about/people/ - 0 errors
 > http://localhost:4000/personas/ - 0 errors
 > http://localhost:4000/playbook/ - 0 errors
 > http://localhost:4000/projects/ - 0 errors
 > http://localhost:4000/roles/ - 0 errors
 > http://localhost:4000/search - 0 errors
 > http://localhost:4000/services - 0 errors
 > http://localhost:4000/topics/ - 0 errors
 > http://localhost:4000/VPAT/Drupal9AccessibilityConformanceReport-December2020.html - 0 errors

✔ 127/127 URLs passed

@dmundra dmundra enabled auto-merge (squash) May 31, 2024 20:56
Copy link
Contributor

@mgifford mgifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dmundra dmundra merged commit f50d83a into main Jun 3, 2024
8 checks passed
@dmundra dmundra deleted the github-workflow-updates branch June 3, 2024 17:11
@dmundra dmundra mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants