Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
When we want to get draft threads we get published ones, not draft ones.
Notice how
is_draft
parameters are used in these functions:OpenCiviWiki/project/accounts/api.py
Lines 124 to 135 in 201368a
and vice versa
OpenCiviWiki/project/accounts/api.py
Lines 111 to 122 in 201368a
Another example:
OpenCiviWiki/project/threads/api.py
Lines 68 to 70 in 201368a
Since
problems
is an empty array, it is not appropriate to add elements by inserting them via index. The correct way is to useappend()
method.I add
api_view(['GET'])
decorators toget_user()
,get_profile()
, andget_card()
functions to give them DRF permissions defined insettings.py
. ThusAnonymousUser
cannot get sensitive user data.Interestingly, GitHub shows my changes as removing files and recreating them. 🤔