Restructure project #1025
Merged
Restructure project #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving Issue #952 and Issue #1004
As discussed in #1004, I renamed
UpdateProfiletoProfileEditForm.I updated
SettingsViewandProfileActivationViewso that they are not FBV anymore.I realized that the activation link in the email is broken There is also another bug: If activation mail is manually changed then an error rises so the project is broken due to the exception I fixed both of them.
I added unit tests for
SettingsViewandProfileActivationViewto improve test coverage. I personally tested these views to be sure that they work well. Seemingly, everything is perfect.