Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gardiner dev #69

Open
wants to merge 31 commits into
base: gardiner
Choose a base branch
from
Open

Gardiner dev #69

wants to merge 31 commits into from

Conversation

chmnata
Copy link

@chmnata chmnata commented Dec 20, 2019

What this pull request accomplishes

  • Re-order tabs and segments
  • Edit baseline description
  • Make it so one-way streets won't have the other direction in the table
  • Add gardiner segments from Wickman <-> Grand

Screenshot of dashboard before

image

Screenshot of dashboard after
image

Issue(s) this solves

What, in particular, needs to reviewed

  • If the order of segments are logical
  • Baseline description

@chmnata chmnata added this to the Gardiner Dashboard V1 milestone Dec 20, 2019
@chmnata chmnata requested a review from radumas December 20, 2019 14:46
@radumas
Copy link
Member

radumas commented Dec 20, 2019

Shortening Segment Names

How do we feel about

image

And removing Ramp

image

Lakeshore segment name directionality

I get for Richmond that the segment names should be reversed, but I find it really confusing on Lakeshore with the two sets of one way segments, it's hard to know if Parliament to Yonge is West of Parliament to Don Rdwy

@chmnata chmnata requested review from cczhu and removed request for radumas December 20, 2019 22:06
cczhu
cczhu approved these changes Dec 20, 2019
View reviewed changes
Copy link

@cczhu cczhu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Natalie wanted me to try to merge this. We failed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cczhu cczhu cczhu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gardiner Dashboard V1
Development

Successfully merging this pull request may close these issues.
3 participants
@chmnata @radumas @cczhu