CU-86drpndnn - Throw a compilation error when variable type declaration doesn't match the assigned value type #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # TODO: check if the annotated type and the value type are the same #86a1ctmwy | ||
| if isinstance(ann_assign.value, ast.Constant): | ||
| annotation_type = self.get_type(ann_assign.value) | ||
| if var_type is not annotation_type: |
There was a problem hiding this comment.
The variable var_type is not defined before it's used. Please ensure that var_type is defined and assigned the correct value before this line.
…on doesn't match the assigned value type
meevee98
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary or solution description
When assigning a variable and defining the type of said as a constant (like a number or hardcoded string) of a different type, it should throw an error.
Platform: