DIG-4807, DIG-5571 #789
Merged
DIG-4807, DIG-5571 #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIG-4807 Content text underline for accessibility
DIG-4807 Content text underline for accessibility
DIG-4807 Content text underline for accessibility
DIG-4807 Content text underline for accessibility
DIG-4807 Content text underline for accessibility
DIG-5470 Added new social media icon, bluesky
DIG-5470 Adding new svg image
DIG-4807 CKEditor text links underline
DIG-4807 CKEditor links
DIG-4807 CKEditor
DIG-4807 Adding underline to CKEditor
DIG-4807 Add underline to links CK Editor
DIG-4807 Add underline to links in CK Editor
DIG-4807 Adding underllinee to linnks in CK editor
Node article header text bug
davidrkupton
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Approved, but it looks like you are setting the anchor to be underlined by default for everything, and then turning off where it is not needed? Would it not be easier to maintain this going forwards to just add the underlines where we do want them (paragraphs and node with formatted text fields)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIG-4807 - Add underline to links in CK Editor
DIG-5571 - Styling error in hero image of article page