Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIG-4417 Fix for text fields inputs on PCs #759

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Conversation

subaha-cob
Copy link
Contributor

DIG-4417 Fix for text fields inputs on PCs

@subaha-cob subaha-cob requested a review from davidrkupton June 26, 2024 13:51
Copy link
Contributor

@davidrkupton davidrkupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change will potentially affect the line height for all textarea inputs across the whole Drupal site.
There are few textareas used, but as we add search etc etc there are more and more.
When it is "inheriting" it takes the line height from the parent, if registry has an issue, maybe the linehight is safer/better to be set on the containing div?

@subaha-cob subaha-cob requested a review from davidrkupton June 27, 2024 14:24
@subaha-cob subaha-cob merged commit e106d8e into production Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants