Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(production) Fix 'Text getting cutoff at the bottom' on Windows #755

Merged
merged 10 commits into from
May 22, 2024
Merged

(production) Fix 'Text getting cutoff at the bottom' on Windows #755

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9dfbc8e
Fix 'Text getting cutoff at the bottom' on Windows
phillipbentonkelly May 7, 2024
ab6387f
Merge pull request #753 from CityOfBoston/fix-txt-cutoff-on-windows
phillipbentonkelly May 7, 2024
291adb4
Update deploy_to_s3.yml
davidrkupton May 8, 2024
8024094
Fix 'Text getting cutoff at the bottom' on Windows wip#2
phillipbentonkelly May 9, 2024
3fd3e67
Merge pull request #754 from CityOfBoston/fix-txt-cutoff-on-windows
phillipbentonkelly May 9, 2024
b1d45ea
Fix secrets typo in workflow
davidrkupton May 9, 2024
fb2e0d3
DIG-4409: Final Marriage Intention fixes before Registry review
phillipbentonkelly May 21, 2024
2641e11
Merge pull request #756 from CityOfBoston/DIG-4409
phillipbentonkelly May 21, 2024
bef9041
DIG-4409v2: Final Marriage Intention fixes before Registry review
phillipbentonkelly May 22, 2024
e36d0f0
Merge pull request #757 from CityOfBoston/DIG-4409v2
phillipbentonkelly May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/deploy_to_s3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,13 @@ jobs:
run: |
if [[ "${{ github.ref_name }}" == "develop" ]]; then
echo "BUCKET_NAME=patterns-stg.boston.gov" >> "${GITHUB_ENV}"
echo "CLOUDFRONT_ID=${{ secrets.STG_CLOUDFRONT_DISTRIBUTION_ID }}" >> "${GITHUB_ENV}"
elif [[ "${{ github.ref_name }}" == "production" ]]; then
echo "BUCKET_NAME=patterns.boston.gov" >> "${GITHUB_ENV}"
echo "CLOUDFRONT_ID=${{ secrets.CLOUDFRONT_DISTRIBUTION_ID }}" >> "${GITHUB_ENV}"
else
echo "BUCKET_NAME=patterns-uat.boston.gov" >> "${GITHUB_ENV}"
echo "CLOUDFRONT_ID=${{ secrets.UAT_CLOUDFRONT_DISTRIBUTION_ID }}" >> "${GITHUB_ENV}"
fi
if [[ ${{ vars.S3_DRY_RUN }} == 1 ]];then
echo "S3_DEST_DIR='DRY_RUN/'" >> "${GITHUB_ENV}"
Expand Down Expand Up @@ -108,7 +111,7 @@ jobs:
id: Invalidate-Cache
uses: chetan/invalidate-cloudfront-action@v2
env:
DISTRIBUTION: ${{ secrets.CLOUDFRONT_DISTRIBUTION_ID }}
DISTRIBUTION: ${{ env.CLOUDFRONT_ID }}
PATHS: "/*"
AWS_REGION: "us-east-1"
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY }}
Expand Down
10 changes: 5 additions & 5 deletions stylesheets/components/form/_textbox.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
margin: 0 0 $sizing-300

&-f
field-height = "calc(%srem + %s * 1)" % ($line-height-600 $border-200)
field-height = "calc(%srem + %s * 1)" % ($line-height-600 $border-150)

font-family: $serif
font-size: 1rem
Expand All @@ -37,7 +37,7 @@
border: $border-200 solid $charles-blue
border-radius: 0 // Safari/iOS rounds input field corners by default

height: field-height
height: 57px
line-height: field-height

padding-left: $sizing-300
Expand All @@ -52,13 +52,13 @@
border-color: $focus-indicator-color

&--sm
field-height-sm = "calc(%srem + %s * 1)" % ($line-height-400 $border-200)
field-height-sm = "calc(%srem + %s * 1)" % ($line-height-400 $border-150)

padding-left: $sizing-200
padding-right: $sizing-200

height: field-height-sm
line-height: field-height-sm
line-height: 35px

&::placeholder
font-style: italic
Expand All @@ -74,7 +74,7 @@
textarea&
&.txt-f--combo
// Need to leave space for a .sel-f--sq element, and its borders
width: "calc(100% - %s - %s * 1)" % ($select-arrow-box-width $border-200)
width: "calc(100% - %s - %s * 1)" % ($select-arrow-box-width $border-150)

input[type=email]&--auto,
input[type=tel]&--auto,
Expand Down
Loading