Refactor layouts #1500
Open
Refactor layouts #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonatank
force-pushed
the
refactor-layouts
branch
13 times, most recently
from
ac78065
to
412c44a
Compare
joonatank
force-pushed
the
refactor-layouts
branch
from
742e174
to
b9bfd05
Compare
There is a single page: customer front page that uses the large style so add $large variable for that.
- remove: unused styles - remove: duplicated code from reservations - remove: duplicated spinner code
- refactor: webstore reservation confirmation - refactor: success page to use SSR for redirect - refactor: cancel payment page to use SSR - remove: unnecesary useOrder hook
- fix: layout issues on mobile - use styled components over classes
fix: layout padding inconsistencies on mobile fix: global styling (tab wrapper)
joonatank
force-pushed
the
refactor-layouts
branch
from
b9bfd05
to
fa92da2
Compare
vincit-matu
reviewed
Nov 15, 2024
Comment on lines
+62
to
+69
| $justify?: | ||
| | "center" | ||
| | "flex-start" | ||
| | "flex-end" | ||
| | "space-between" | ||
| | "space-around" | ||
| | "space-evenly"; | ||
| $align?: "center" | "flex-start" | "flex-end" | "baseline" | "stretch"; |
There was a problem hiding this comment.
This doesn't take into account whether justify/align is for content or for items. All combinations of these are quite often used. Should the variable names maybe be justifyContent and alignItems - to leave room for justify-items/align-content?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
Pages are now defined as a
flexbase layout, more complex pages addgridwrapper inside the flex to control two columns. Anything that is not a general purpose component is expected to primarily export fragments not divs and allow the page layout handle margins.flex/gridwith gaps over custompaddingandmarginper component.common/styles/utilincludingFlexcomponent that should solve most basic use cases.common/styles/global.scssinstead of random places.$legacyattributes fromHcomponents.<H2 as="h1">h1should stay consistent unless there is very specific case (ex. front page hero section).admin-ui🧪 Test plan
🎫 Tickets