fix: remove prefetch from calendar link

City-of-Helsinki · Nov 16, 2024 · 6244b75 · 6244b75
1 parent 9dd73d1
commit 6244b75
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/apps/ui/components/common/ButtonLikeLink.tsx b/apps/ui/components/common/ButtonLikeLink.tsx
@@ -12,3 +12,9 @@ export const ButtonLikeLink = styled(Link)<ButtonStyleProps>`
   ${fontMedium}
   gap: var(--spacing-s);
 `;
+
+export const ButtonLikeExternalLink = styled.a<ButtonStyleProps>`
+  ${ButtonCss}
+  ${fontMedium}
+  gap: var(--spacing-s);
+`;
diff --git a/apps/ui/components/reservation/ReservationConfirmation.tsx b/apps/ui/components/reservation/ReservationConfirmation.tsx
@@ -22,7 +22,7 @@ import { getReservationUnitInstructionsKey } from "@/modules/reservationUnit";
 import { getTranslation } from "@/modules/util";
 import { BlackButton } from "@/styles/util";
 import { Paragraph } from "./styles";
-import { ButtonLikeLink } from "../common/ButtonLikeLink";
+import { ButtonLikeExternalLink } from "../common/ButtonLikeLink";
 import { getReservationUnitPath, reservationsPath } from "@/modules/urls";
 
 type Node = NonNullable<ReservationQuery["reservation"]>;
@@ -140,16 +140,15 @@ function ReservationConfirmation({
       </Paragraph>
       {reservation.state === ReservationStateChoice.Confirmed && (
         <ActionContainer1 style={{ marginBottom: "var(--spacing-2-xl)" }}>
-          <ButtonLikeLink
+          <ButtonLikeExternalLink
             size="large"
             disabled={!reservation.calendarUrl}
             data-testid="reservation__confirmation--button__calendar-url"
             href={reservation.calendarUrl ?? ""}
-            locale={false}
           >
             {t("reservations:saveToCalendar")}
             <IconCalendar aria-hidden />
-          </ButtonLikeLink>
+          </ButtonLikeExternalLink>
           {order?.receiptUrl && (
             <BlackButton
               data-testid="reservation__confirmation--button__receipt-link"

diff --git a/apps/ui/pages/reservations/[id]/index.tsx b/apps/ui/pages/reservations/[id]/index.tsx
@@ -57,7 +57,10 @@ import {
 import { base64encode, filterNonNullable } from "common/src/helpers";
 import { containsField, containsNameField } from "common/src/metaFieldsHelpers";
 import { NotModifiableReason } from "@/components/reservation/NotModifiableReason";
-import { ButtonLikeLink } from "@/components/common/ButtonLikeLink";
+import {
+  ButtonLikeLink,
+  ButtonLikeExternalLink,
+} from "@/components/common/ButtonLikeLink";
 import { useRouter } from "next/router";
 import { successToast } from "common/src/common/toast";
 import { ReservationPageWrapper } from "@/components/reservations/styles";
@@ -514,14 +517,14 @@ function Reservation({
                 </ButtonLikeLink>
               )}
               {canTimeBeModified && (
-                <ButtonLikeLink
+                <ButtonLikeExternalLink
                   size="large"
                   href={getReservationPath(reservation.pk, "edit")}
                   data-testid="reservation-detail__button--edit"
                 >
                   {t("reservations:modifyReservationTime")}
                   <IconCalendar aria-hidden />
-                </ButtonLikeLink>
+                </ButtonLikeExternalLink>
               )}
               {isCancellable && (
                 <ButtonLikeLink