Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recurring reservation deny mutation endpoint #1428

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add recurring reservation deny mutation endpoint #1428

merged 1 commit into from
Nov 14, 2024

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Nov 13, 2024 •
edited
Loading

🛠️ Changelog

  • Endpoint for mass denying upcoming reservations in a reservation series
  • Also fix issues related to reservee being able to modify other users' reservations

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu added fix Fixes a bug feature Adds a new feature labels Nov 13, 2024
@matti-lamppu matti-lamppu self-assigned this Nov 13, 2024
@matti-lamppu matti-lamppu marked this pull request as ready for review November 13, 2024 12:36
vergama
vergama approved these changes Nov 13, 2024
View reviewed changes
Copy link

@vergama vergama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@matti-lamppu
Add recurring reservation deny mutation endpoint
4eb272e 
Also fix issues related to reservee being able to modify
other user's reservations.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matti-lamppu matti-lamppu merged commit 8f4d410 into main Nov 14, 2024
6 checks passed
@matti-lamppu matti-lamppu deleted the recurring-reservation-mass-deny branch November 14, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vergama vergama vergama approved these changes

@ranta ranta Awaiting requested review from ranta

Assignees

@matti-lamppu matti-lamppu

Labels
feature Adds a new feature fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matti-lamppu @vergama