Add entrypoint script #40
Conversation
docker-compose.yml
Outdated
There was a problem hiding this comment.
What would be the right place to store Django superuser credentials? A separate env file?
entrypoint.sh
Outdated
| @@ -0,0 +1,5 @@ | |||
| #!/bin/sh | |||
| python manage.py migrate | |||
| python manage.py createsuperuser --noinput | |||
There was a problem hiding this comment.
Usually superusers are created to the database, and not in docker start. Also, it's one time thing, and something that happens differently depending on database purpose and location (local, test, prod).
There was a problem hiding this comment.
I thought it might be nice to be able to automatically create an initial superuser from environment variables that are set in secrets, during development. If it seems like an unnecessary feature or a risk, I don't mind if it's removed.
There was a problem hiding this comment.
since the user creds go into database that needs to be handled persistently, I think its place is not in container
usually automated local dev superuser creation would be set when adding fixtures/test data to the db
There was a problem hiding this comment.
I agree, manually creating manage.py createsuperuser or loading it from a fixture is a better idea in many/all cases.
There was a problem hiding this comment.
I removed superuser creation and rebased the branch.
The entrypoint script runs migrations
laurigates
force-pushed
the
add_entrypoint_migrations
branch
from
15ab8d4
to
0dbefa7
Compare
The entrypoint script runs migrations and creates a superuser based on environment variables.