Make CML 2.8 work a on AWS and Azure #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cml aws deploy fix * fix azure deployment * add missing comments --------- Co-authored-by: Oliver Uhlar -X (ouhlar - PANTHEON TECH SRO at Cisco) <[email protected]>
- reverting the allowed_ipv4_subnet changes from previous commit - update the VMX patch script - fix some white space issues in shell scripts
- overall, should fix #27 to allow deployments on AWS and Azure with 2.8 - changed variable names for AWS access and secret keys to start with aws_ (e.g. TF_VAR_access_key -> TF_VAR_aws_access_key), same for Azure subscription_id and tenant_id. - do product licensing using the PCL instead of the cml.sh script (fixes #28) - fix letsencrypt certificate installation for nginx and Cockpit - add i386 repository to allow installation of older libraries for IOL compatibility - whitespace and formatting of files - for Azure, use the "minimal" SKU of the Noble image (instead of "server") - slightly more comprehensive log output in cml.sh to see where time is spent when deploying
rschmied
commented
Jan 9, 2025
rschmied
commented
Jan 9, 2025
There was a problem hiding this comment.
@ouhlar -- if you want to have a look, it works for me on Azure but I haven't tested on AWS, yet. Also, @amieczko-te -- does this look OK to you?
|
There's README changes that are required, still. E.g. version bump and explanation that THIS now works with 2.8 etc. |
@rschmied |
- improved the license script to allow for no license to be installed - removed the unnecessary wait in the customize script - some cosmetic output fixes - documentation updates, including the CHANGELOG - fixed the .envrc.example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for CML 2.8 and more
aws_ (e.g. TF_VAR_access_key -> TF_VAR_aws_access_key), same for Azure
subscription_id and tenant_id.
Use PCL for licensing #28)
compatibility
"server")
spent when deploying