Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for arm containers #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add support for arm containers #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a46faf
feat: add support for arm containers
bardiharborow Dec 16, 2023
c909ca7
Merge branch 'master' into patch-13
marboledacci Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .circleci/test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ executors:
linux:
docker:
- image: cimg/base:stable
linux-arm:
docker:
- image: cimg/base:stable
resource_class: arm.medium
Comment on lines +19 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cimg/base image don't have an ARM alternative, so this won't work.
To have ARM executors, they should be machine type.

macos:
macos:
xcode: 15.1.0
Expand Down Expand Up @@ -191,22 +195,22 @@ workflows:
filters: *filters
matrix:
parameters:
os: [linux, macos, machine]
os: [linux, linux-arm, macos, machine]
- integration-test-install-pnpm:
filters: *filters
matrix:
parameters:
os: [ linux, macos, machine ]
os: [ linux, linux-arm, macos, machine ]
- integration-test-install-latest:
filters: *filters
matrix:
parameters:
os: [linux, macos, machine]
os: [linux, linux-arm, macos, machine]
- integration-test-install-lts:
filters: *filters
matrix:
parameters:
os: [linux, macos, machine]
os: [linux, linux-arm, macos, machine]
- node/test:
filters: *filters
name: node-npm-jest-test-job
Expand Down
4 changes: 4 additions & 0 deletions src/executors/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ parameters:
- xlarge
- 2xlarge
- 2xlarge+
- arm.medium
- arm.large
- arm.xlarge
- arm.2xlarge

docker:
- image: cimg/node:<<parameters.tag>>
Expand Down