Add Modal for Deployment Selection #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datomo
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Thanks @PatrikBuetler, the changes make the modal look nice and work mostly as intended.
Sadly, the selection currently seems not correctly set the deployment in the request, which leads to the incorrect deployment in the end.
This branch request:
Master request :
As soon as this is adjusted, this is ready to merge.
|
@datomo Thanks for the tip. It's working now. Please review and merge if everything looks good. |
datomo
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improved version of the deployment selection using Chronos style modals as used elsewhere.