Merge pull request #57 from ChoTotOSS/fix/turn-off-no-unused-var-js

feat: make no unused var error
ChoTotOSS · Sep 20, 2023 · 4c24fc1 · 4c24fc1
2 parents 21aaa17 + 76439fd
commit 4c24fc1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/orange-flies-greet.md b/.changeset/orange-flies-greet.md
@@ -0,0 +1,5 @@
+---
+'@chotot/eslint-config-base': patch
+---
+
+turn off no-unused-vars for ts file, this is handled by typescript-eslint plugin, also make it error instead of warning
diff --git a/packages/eslint-config-base/src/rulesets.js b/packages/eslint-config-base/src/rulesets.js
@@ -815,6 +815,7 @@ const typescriptEslintPluginRules = {
   'no-extra-semi': 'off',
   'no-loss-of-precision': 'off',
   'no-shadow': 'off',
+  'no-unused-vars': 'off',
   // Require that function overload signatures be consecutive.
   // https://typescript-eslint.io/rules/adjacent-overload-signatures
   '@typescript-eslint/adjacent-overload-signatures': 'error',
@@ -1138,7 +1139,7 @@ const typescriptEslintPluginRules = {
   '@typescript-eslint/no-loss-of-precision': 'error',
   // Disallow unused variables.
   // https://typescript-eslint.io/rules/no-unused-vars
-  '@typescript-eslint/no-unused-vars': 'warn',
+  '@typescript-eslint/no-unused-vars': 'error',
   // Disallow empty functions.
   // https://typescript-eslint.io/rules/no-empty-function
   '@typescript-eslint/no-empty-function': 'off',