-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sccache to build-test.yml
#418
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 8135307016Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this using some sccache service?
it would seem simpler (and perhaps more reliable) to use the github action cache
action and point it to the cargo target
directory (which essentially is a ccache already)
|
||
- name: Set sccache env vars | ||
run: | | ||
echo "SCCACHE_GHA_ENABLED=true" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "SCCACHE_GHA_ENABLED=true" >> "$GITHUB_ENV" | |
echo "SCCACHE_GHA_ENABLED=on" >> "$GITHUB_ENV" |
according to: https://github.com/mozilla/sccache/blob/main/docs/GHA.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/mozilla-actions/sccache-action#conditionally-run-cache-and-enable-it says true
which is where I copied it from. I haven't actually merged any PR using this though so we don't have any in-house precedence.
sccache has builtin GitHub Actions cache support. In my mind it can be way smarter than caching a directory this way. I hadn't dug into it but it might be able to be a global cache instead of per-repository with lots of duplication. |
No description provided.