Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(query): change amazonaws.cn links to aws.amazon.com #7288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update(query): change amazonaws.cn links to aws.amazon.com #7288

wants to merge 1 commit into from

Conversation

connorg
Copy link

@connorg connorg commented Oct 22, 2024 •
edited
Loading

Closes: no issue filed, but I can file one if required

Reason for Proposed Changes

  • Most AWS queries link to docs.aws.amazon.com. Two link to docs.amazonaws.cn.
  • Consistency seems preferable in any case. But these particular links can be a problem in highly-restrictive network environments where users are unable to resolve or access region-specific documentation such as subdomains of .cn.

Proposed Changes

  • Change textual occurrences of docs.amazonaws.cn to docs.aws.amazon.com
    • I'm not familiar with any auto-generation scripts for docs, but updated the text throughout the repository in hopes that that does the trick.

I submit this contribution under the Apache-2.0 license.

@connorg connorg requested a review from a team as a code owner October 22, 2024 18:15
@github-actions github-actions bot added community Community contribution query New query feature aws PR related with AWS Cloud labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
aws PR related with AWS Cloud community Community contribution query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@connorg