Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yaml): Added Ignore lines by comments to yaml #4420 #4486

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

#4420 #4419

Proposed Changes

  • Users can now ignore lines by comments in the original file
  • lines containing comments are now excluded as well for yaml
  • this feature should only be enabled when all parsers support this feature

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added feature New feature go Pull requests that update Go code labels Nov 5, 2021
@joaoReigota1 joaoReigota1 added this to the Core Engineering milestone Nov 5, 2021
@joaoReigota1 joaoReigota1 requested a review from a team November 5, 2021 18:00
@joaoReigota1 joaoReigota1 self-assigned this Nov 5, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Nov 5, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Nov 5, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

@joaoReigota1 joaoReigota1 changed the title feat(yaml): Added Ignore lines by comments to yaml #4480 feat(yaml): Added Ignore lines by comments to yaml #4420 Nov 5, 2021
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaoReigota1 joaoReigota1 merged commit 44ea29c into master Nov 8, 2021
@joaoReigota1 joaoReigota1 deleted the feat/add_ignore_comments_yaml branch November 8, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants