Support PR Decoration For BB On-cloud and On-prem(AST-70121) #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
elchananarb
reviewed
Nov 14, 2024
AlvoBen
reviewed
Nov 14, 2024
elchananarb
reviewed
Nov 14, 2024
AlvoBen
previously approved these changes
Nov 14, 2024
# Conflicts: # cmd/main.go # internal/commands/util/pr.go # internal/commands/util/pr_test.go # internal/params/binds.go # internal/params/envs.go # internal/params/flags.go # internal/params/keys.go # internal/wrappers/pr-http.go # internal/wrappers/pr.go # test/integration/pr_test.go # test/integration/util_command.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Support PR decoration command for Bitbucket.
References
https://checkmarx.atlassian.net/browse/AST-70121
Testing
The integration tests covered successful and failed scenarios, verifying the system's behavior in both on-premises and cloud environments.
Testing a scenario where a scan is running.
Unit test to confirm that all required parameters have been passed.
Unit test to verify the correctness of the function that converts the repo name to the slug format.
Checklist