fixes for linter

Checkmarx · Nov 14, 2024 · 2c639e5 · 2c639e5
1 parent dcfdddf
commit 2c639e5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/internal/commands/util/pr_test.go b/internal/commands/util/pr_test.go
@@ -8,6 +8,10 @@ import (
 	"gotest.tools/assert"
 )
 
+const (
+	token = "token"
+)
+
 func TestNewGithubPRDecorationCommandMustExist(t *testing.T) {
 	cmd := PRDecorationGithub(nil, nil, nil)
 	assert.Assert(t, cmd != nil, "PR decoration command must exist")
@@ -87,15 +91,13 @@ func TestUpdateAPIURLForAzureOnPrem_whenAPIURLIsNotSet_ShouldReturnCloudAPIURL(t
 }
 
 func TestUpdateScmTokenForAzureOnPrem_whenUserNameIsSet_ShouldUpdateToken(t *testing.T) {
-	token := "token"
 	username := "username"
 	expectedToken := username + ":" + token
 	updatedToken := updateScmTokenForAzure(token, username)
 	asserts.Equal(t, expectedToken, updatedToken)
 }
 
 func TestUpdateScmTokenForAzureOnPrem_whenUserNameNotSet_ShouldNotUpdateToken(t *testing.T) {
-	token := "token"
 	username := ""
 	expectedToken := token
 	updatedToken := updateScmTokenForAzure(token, username)

diff --git a/internal/wrappers/pr-http.go b/internal/wrappers/pr-http.go
@@ -21,7 +21,7 @@ type PRHTTPWrapper struct {
 	azurePath  string
 }
 
-func NewHTTPPRWrapper(githubPath, gitlabPath string, azurePath string) PRWrapper {
+func NewHTTPPRWrapper(githubPath, gitlabPath, azurePath string) PRWrapper {
 	return &PRHTTPWrapper{
 		githubPath: githubPath,
 		gitlabPath: gitlabPath,