Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made sidebar + header bar sticky #35

Merged
merged 3 commits into from
Jan 27, 2025
Merged

made sidebar + header bar sticky #35

merged 3 commits into from
Jan 27, 2025

Conversation

kohrachel
Copy link
Collaborator

As said in title. Changed some ordering of components in appRoutes.tsx: moved sidebar outside of the <div> for the home page, and added some conditional padding in the home page's <div> to ensure the sidebar doesn't overlap the content.

Remaining TODOs:

  • @kohrachel fix sidebar behavior on some mobile/tablet screens (add breakpoints for collapsing)
  • fix home page behavior -- background color doesn't fill the whole screen (see the second preview with the narrower screen, the gray stops before the end of the page).
    • Note: setting height: min-content on the parent element solves this but broke the centering of the sidebar for me

Some previews below:

Full-screen (desktop)

demo

Narrow-screen (desktop)

demo2

@kohrachel kohrachel requested a review from yifeifang11 January 27, 2025 05:37
Copy link
Collaborator

@yifeifang11 yifeifang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this looks awesome thank you! maybe this can be next week's task (to make sure the background behind the sidebar is also grey) but this works perfectly for our midpoint symposium

@yifeifang11 yifeifang11 merged commit 47c1ec7 into main Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants