Implementation - QuoteChar #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsrahulsehgal
pushed a commit
to itsrahulsehgal/cQube-ingestion
that referenced
this pull request
Oct 3, 2023
…setup removed un-used dependency ChakshuGautam#164
techsavvyash
requested changes
Oct 7, 2023
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "globals": { | |||
| "onlyCreateWhitelisted": true | |||
| "onlyCreateWhitelisted": true, | |||
There was a problem hiding this comment.
remove the code related to onlyCreateWhiteList from this PR.
There was a problem hiding this comment.
add more complex test cases checking for this quoteChar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new config parameter along with test cases to increase coverage ( For the issue #64 )