Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal/client): Introduction of Client that implements LockImportRun, BlockchainEvents, and PrecommitActions. #4477

Open
wants to merge 16 commits into
base: refactor/client-db
Choose a base branch
from
Open

feat(internal/client): Introduction of Client that implements LockImportRun, BlockchainEvents, and PrecommitActions. #4477

wants to merge 16 commits into from

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented Jan 17, 2025 •
edited
Loading

Changes

  • Introduction of BlockchainEvents interface.
  • Introduction of PreCommitActions interface.
  • Introduction of new Client type that implements both BlockchainEvents and PrecommitActions interfaces.
  • Introduction of Client.LockImportRun function that will be used as a dependency in future work.
  • Unpinning functionality and background goroutine within Client to unpin blocks from memory based on notifications
  • Pubsub module utilized in sending out storage notifications from Client.

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

closes #4455, #4456, #4457

@timwu20 timwu20 force-pushed the tim/client-notifications branch 2 times, most recently from b93e7cc to cf9fb20 Compare January 17, 2025 20:23
@timwu20 timwu20 force-pushed the refactor/client-db branch from 8fe8796 to 8cc1aa9 Compare January 19, 2025 06:43
@timwu20 timwu20 force-pushed the tim/client-notifications branch 2 times, most recently from e690825 to 0fc61bb Compare January 19, 2025 07:02
@timwu20 timwu20 force-pushed the tim/client-notifications branch from 0fc61bb to fdc527e Compare January 19, 2025 07:04
@timwu20 timwu20 marked this pull request as ready for review January 20, 2025 14:55
@timwu20 timwu20 changed the title Tim/client notifications feat(client): Introduction of Client that implements LockImportRun, BlockchainEvents, and PrecommitActions. Jan 20, 2025
@timwu20 timwu20 changed the title feat(client): Introduction of Client that implements LockImportRun, BlockchainEvents, and PrecommitActions. feat(internal/client): Introduction of Client that implements LockImportRun, BlockchainEvents, and PrecommitActions. Jan 20, 2025
@timwu20 timwu20 force-pushed the tim/client-notifications branch from 82c2680 to 3ba7d9e Compare January 20, 2025 15:03
haikoschol
haikoschol approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@haikoschol haikoschol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some typos & nits

internal/client/api/backend.go Outdated Show resolved Hide resolved
internal/client/api/notifications.go Outdated Show resolved Hide resolved
internal/client/api/registry.go Outdated Show resolved Hide resolved
internal/client/client.go Outdated Show resolved Hide resolved
internal/client/client.go Outdated Show resolved Hide resolved
internal/client/notification_pinning.go Show resolved Hide resolved
internal/client/utils/pubsub/pubsub.go Show resolved Hide resolved
dimartiro
dimartiro approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@dimartiro dimartiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimartiro dimartiro dimartiro approved these changes

@haikoschol haikoschol haikoschol approved these changes

@P1sar P1sar Awaiting requested review from P1sar

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timwu20 @haikoschol @dimartiro