Add TODO comment on EncodeAndHash

ChainSafe · Jul 20, 2022 · 4acacd8 · 4acacd8
1 parent f34baec
commit 4acacd8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/internal/trie/node/hash.go b/internal/trie/node/hash.go
@@ -82,6 +82,9 @@ func (n *Node) MerkleValue(isRoot bool) (merkleValue []byte, err error) {
 // EncodeAndHash returns the encoding of the node and the
 // Merkle value of the node. See the `MerkleValue` and `MerkleValueRoot`
 // methods for more details on the value of the Merkle value.
+// TODO change this function to write to an encoding writer
+// and a merkle value writer, such that buffer sync pools can be used
+// by the caller.
 func (n *Node) EncodeAndHash(isRoot bool) (encoding, merkleValue []byte, err error) {
 	if !n.Dirty && n.Encoding != nil && n.HashDigest != nil {
 		return n.Encoding, n.HashDigest, nil

diff --git a/lib/trie/trie_test.go b/lib/trie/trie_test.go
@@ -492,9 +492,10 @@ func Test_Trie_Hash(t *testing.T) {
 					Descendants: 1,
 					Children: padRightChildren([]*Node{
 						{
-							Key:      []byte{9},
-							Value:    []byte{1},
-							Encoding: []byte{0x41, 0x09, 0x04, 0x01},
+							Key:        []byte{9},
+							Value:      []byte{1},
+							Encoding:   []byte{0x41, 0x09, 0x04, 0x01},
+							HashDigest: []byte{0x41, 0x09, 0x04, 0x01},
 						},
 					}),
 				},