Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): implement Filecoin.F3GetOrRenewParticipationTicket and Filecoin.F3Participate #4920

Merged
merged 9 commits into from
Oct 23, 2024
Merged

feat(rpc): implement Filecoin.F3GetOrRenewParticipationTicket and Filecoin.F3Participate #4920

merged 9 commits into from
Oct 23, 2024
+422 −159

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Oct 22, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • implement Filecoin.F3GetOrRenewParticipationTicket
  • update Filecoin.F3Participate against the new spec
  • update Filecoin.F3ListParticipants against the new spec

Reference issue to close (if applicable)

Closes #4861

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 force-pushed the hm/F3GetOrRenewParticipationTicket branch from 91c1b5e to 040f21e Compare October 22, 2024 08:32
@hanabi1224 hanabi1224 marked this pull request as ready for review October 22, 2024 08:36
@hanabi1224 hanabi1224 requested a review from a team as a code owner October 22, 2024 08:36
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and elmattic and removed request for a team October 22, 2024 08:36
@hanabi1224 hanabi1224 force-pushed the hm/F3GetOrRenewParticipationTicket branch from a68252f to f6cf691 Compare October 22, 2024 08:42
LesnyRumcajs
LesnyRumcajs approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rock-solid

@hanabi1224 hanabi1224 linked an issue Oct 22, 2024 that may be closed by this pull request
Implement RPC method Filecoin.F3ListParticipants #4909
Closed
2 tasks
@hanabi1224 hanabi1224 mentioned this pull request Oct 22, 2024
Closed
2 tasks
@hanabi1224 hanabi1224 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 678c996 Oct 23, 2024
35 checks passed
@hanabi1224 hanabi1224 deleted the hm/F3GetOrRenewParticipationTicket branch October 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@elmattic elmattic Awaiting requested review from elmattic elmattic is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RPC method Filecoin.F3ListParticipants Implement ticket based F3 participation lease
3 participants
@hanabi1224 @lemmih @LesnyRumcajs