Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failing macos build, wrong arch, missing wallet #4905

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: failing macos build, wrong arch, missing wallet #4905

merged 2 commits into from
Oct 17, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Oct 16, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • fixes failing build for MacOS (missing Go setup),
  • fixes wrong architecture for the build (macos-latest moved to arm-based workers)
  • fixes missing wallet binary.
  • removes legacy documentation

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner October 16, 2024 13:49
@LesnyRumcajs LesnyRumcajs requested review from elmattic and sudo-shashank and removed request for a team October 16, 2024 13:49
hanabi1224
hanabi1224 reviewed Oct 16, 2024
View reviewed changes
.github/workflows/release.yml Outdated
- name: Cargo Build
run: cargo build --release --bin forest --bin forest-cli --bin forest-tool
run: cargo build --release --bin forest --bin forest-cli --bin forest-tool --bin forest-wallet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not make install

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll go ahead and simplify it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanabi1224 It should be good now, I made it more generic and hopefully less likely to need additional maintenance in case we add more binaries.

@LesnyRumcajs LesnyRumcajs marked this pull request as draft October 16, 2024 13:52
@LesnyRumcajs LesnyRumcajs force-pushed the fix-release-binaries branch 2 times, most recently from 464a0c5 to ed81e43 Compare October 17, 2024 10:09
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review October 17, 2024 10:10
@elmattic elmattic added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 0193c4e Oct 17, 2024
39 checks passed
@elmattic elmattic deleted the fix-release-binaries branch October 17, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@elmattic elmattic elmattic approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LesnyRumcajs @hanabi1224 @elmattic