Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sha256 wide chip for input lengths not multiple of 4 #64

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix Sha256 wide chip for input lengths not multiple of 4 #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lightclient-circuits/src/gadget/crypto/sha256_wide.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ impl<'a, F: Field> HashInstructions<F> for Sha256ChipWide<'a, F> {
builder: &mut Self::CircuitBuilder,
input: impl IntoIterator<Item = QuantumCell<F>>,
) -> Result<Vec<AssignedValue<F>>, Error> {
let assigned_bytes = input
let mut assigned_bytes = input
.into_iter()
.map(|cell| match cell {
QuantumCell::Existing(v) => v,
Expand Down Expand Up @@ -75,8 +75,14 @@ impl<'a, F: Field> HashInstructions<F> for Sha256ChipWide<'a, F> {
.map(|i| QuantumCell::Constant(gate.pow_of_two()[i * 8]))
.collect_vec();

// Following code will check the consitency of halo2-lib input bytes with their word representation in halo2 vanilla
// Since words are 4 bytes each, we extend the input bytes to be a multiple of 4 with zero bytes in a same way as it's done in vanilla during witness assignment.
assigned_bytes.resize_with(num_input_words * 4, || builder.main().load_zero());

for r in 0..num_input_rounds {
for w in 0..(num_input_words - r * NUM_WORDS_TO_ABSORB) {
let remaining_words = num_input_words - r * NUM_WORDS_TO_ABSORB;

for w in 0..std::cmp::min(remaining_words, NUM_WORDS_TO_ABSORB){
let i = (r * NUM_WORDS_TO_ABSORB + w) * 4;
let checksum = gate.inner_product(
builder.main(),
Expand Down Expand Up @@ -121,3 +127,4 @@ pub fn word_to_bytes_le<F: Field>(
.chain(to_bytes_le::<_, 16>(&word.hi(), gate, ctx))
.collect()
}

Loading