Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-704: Remove launch_review package #44

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

PAINTROID-704: Remove launch_review package #44

wants to merge 8 commits into from

Conversation

bhav-khurana
Copy link
Contributor

Ticket

PAINTROID 704

Summary

Removed the launch_review package and used the url_launcher package instead as the former uses/overrides a deprecated API. The user will now be redirected to the app on the Play Store/App store on clicking the Rate Us button.

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

@bhav-khurana
Copy link
Contributor Author

@bakicelebi I have used the url_launcher package instead of the suggested in_app_review as the latter also uses a deprecated API.

@bhav-khurana
Copy link
Contributor Author

bhav-khurana commented Jan 6, 2024 •
edited
Loading

@juliajulie95 @bakicelebi can you please suggest any possible changes?

@bhav-khurana
Copy link
Contributor Author

@bakicelebi @juliajulie95 Is there anything else that is required?

@juliajulie95
Copy link
Contributor

Please resolve your conflicts :)

@msesko
Copy link
Contributor

msesko commented Feb 17, 2024

@bhav-khurana please resolve conflicts with Catrobat:develop so I can review.

@msesko
Copy link
Contributor

msesko commented Feb 22, 2024

@bhav-khurana please resolve conflicts with Catrobat:develop so I can review.

Hi, did you resolve conflicts? To me it says there are still conflicts.

@bhav-khurana
Copy link
Contributor Author

@bhav-khurana please resolve conflicts with Catrobat:develop so I can review.

Hi, did you resolve conflicts? To me it says there are still conflicts.

Actually i was a bit engaged with other stuff for a couple of days.. will push the changes by tomorrow :)

@bhav-khurana
Copy link
Contributor Author

@msesko I have resolved the conflicts. Can you please review?

@msesko
Copy link
Contributor

msesko commented Feb 23, 2024

@msesko I have resolved the conflicts. Can you please review?

Will do tmrw.

@bhav-khurana
Copy link
Contributor Author

@msesko are there any changes required?

msesko
msesko approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@msesko msesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also works for me on iOS.

juliajulie95
juliajulie95 reviewed Apr 14, 2024
View reviewed changes
packages/features/landing_page_screen/lib/src/components/main_overflow_menu.dart
final url = Uri.parse(
Platform.isAndroid
? 'market://details?id=$appId'
: 'https://apps.apple.com/at/app/pocket-code/id1117935892',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the variable and change its value.
iOSAppId would be obsolete right now.

@juliajulie95 juliajulie95 marked this pull request as draft April 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajulie95 juliajulie95 juliajulie95 left review comments

@msesko msesko msesko approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhav-khurana @juliajulie95 @msesko