Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix booleans in values.yaml file #581

Merged
merged 3 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/templates/cdn-invalidator-sub/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and (include "carto.baseUrl" .) (eq .Values.appConfigValues.httpCacheEnabled "true") (not .Values.cartoConfigValues.onlyRunRouter) }}
{{- if and (include "carto.baseUrl" .) (.Values.appConfigValues.httpCacheEnabled) (not .Values.cartoConfigValues.onlyRunRouter) }}
apiVersion: {{ include "common.capabilities.deployment.apiVersion" . }}
kind: Deployment
metadata:
Expand Down
2 changes: 1 addition & 1 deletion chart/templates/http-cache/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and (include "carto.baseUrl" .) (eq .Values.appConfigValues.httpCacheEnabled "true") (not .Values.cartoConfigValues.onlyRunRouter) }}
{{- if and (include "carto.baseUrl" .) (.Values.appConfigValues.httpCacheEnabled) (not .Values.cartoConfigValues.onlyRunRouter) }}
apiVersion: {{ include "common.capabilities.deployment.apiVersion" . }}
kind: Deployment
metadata:
Expand Down
16 changes: 8 additions & 8 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ appConfigValues:
## @param appConfigValues.storageProvider Indicate the storage provider for the bucket. Valid values are: `gcp`, `s3` & `azure-blob`
storageProvider: "gcp"
## @param appConfigValues.httpCacheEnabled Enable the internal httpCache
httpCacheEnabled: "true"
httpCacheEnabled: true
## @param appConfigValues.importAwsRoleArn ARN Role to be used to import files from the bucket
importAwsRoleArn: ""
## @param appConfigValues.exportAwsRoleArn ARN Role to be used to export files from the app
exportAwsRoleArn: ""
## @param appConfigValues.workspaceImportsBucket Bucket to be used to store metadata of the workspace
workspaceImportsBucket: ""
## @param appConfigValues.workspaceImportsPublic Indicate if the imports could be accessed publicly
workspaceImportsPublic: "true"
workspaceImportsPublic: true
## @param appConfigValues.workspaceThumbnailsBucket Bucket to be used to store the thumbnails generated in the app
workspaceThumbnailsBucket: ""
## @param appConfigValues.azureStorageAccount Azure storage account to be used in the app if Azure Blob is the storage provider
Expand All @@ -26,15 +26,15 @@ appConfigValues:
## @param appConfigValues.thumbnailsBucketExternalURL Bucket URL to be used to store the thumbnails generated in the app
thumbnailsBucketExternalURL: ""
## @param appConfigValues.workspaceThumbnailsPublic Indicate if the thumbnails could be accessed publicly
workspaceThumbnailsPublic: "true"
workspaceThumbnailsPublic: true
## @param appConfigValues.googleCloudStorageProjectId If the bucket is GCP, the ProjectId to be used
googleCloudStorageProjectId: ""
## @param appConfigValues.awsS3Region If the bucket is S3, the region to be used
awsS3Region: ""
## @param appConfigValues.bigqueryOauth2ClientId The Client ID used in BigQuery OAuth connections using Sign in with Google instead of providing a service account key.
bigqueryOauth2ClientId: ""
## @param appConfigValues.enableTrackJS By default, TrackJS will gather information about end-user browser, you can disable it setting this parameter to false
enableTrackJS: "true"
enableTrackJS: true
## @param appConfigValues.ssoOrganizationId SSO organization ID provided by CARTO used to configure the SSO in the app.
ssoOrganizationId: ""
defaultAtLocation:
Expand Down Expand Up @@ -87,7 +87,7 @@ replicated:
## Global configuration provided by CARTO. If you changed something from this section probably your self-hosted is going to stop working.
cartoConfigValues:
## @param cartoConfigValues.enableErrorResponseStackTrace Enable stack traces in the container responses
enableErrorResponseStackTrace: "false"
enableErrorResponseStackTrace: false
## @param cartoConfigValues.cartoAccApiDomain Domain of the Account API of Carto.
cartoAccApiDomain: ""
## @param cartoConfigValues.cartoAccGcpProjectId GCP project ID of the Carto Accounts.
Expand All @@ -107,13 +107,13 @@ cartoConfigValues:
## @param cartoConfigValues.launchDarklyClientSideId LaunchDarkly ClientSideId (by www) used to enable/disable features.
launchDarklyClientSideId: ""
## @param cartoConfigValues.cartoDataWarehouseEnabled Enable the Carto Data Warehouse for the self-hosted.
cartoDataWarehouseEnabled: "false"
cartoDataWarehouseEnabled: false
## @param cartoConfigValues.dataObservatoryProjectId GCP project ID of the Carto Data Observatory.
dataObservatoryProjectId: ""
## @param cartoConfigValues.ingressTestingMode Enable router testing mode for the application. This will deploy the router in testing mode serving a simple page to check that it works without routing traffic to other components.
ingressTestingMode: "false"
ingressTestingMode: false
## @param cartoConfigValues.onlyRunRouter Enable only the router component in the installation. This will just deploy the router component. Useful to check the ingress layer together with the option `cartoConfigValues.ingressTestingMode`.
onlyRunRouter: "false"
onlyRunRouter: false

## @section App secret
## Global secrets to be edited by the client
Expand Down
Loading