Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking change: update .Values.tlsCerts and ingress resources #544

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

alvarorm22
Copy link
Contributor

@alvarorm22 alvarorm22 commented Jun 3, 2024

Description of the change

  • Update TLS Certificates configuration
  • Update Ingress resources

TLS Certificates

With these changes, we are going from

tlsCerts:
  httpsEnabled: false
  autoGenerate: false
  existingSecret:
    name: ""
    keyKey: ""
    certKey: ""

to:

router:
  httpsEnabled: false
  tlsCertificates:
    certificateValueBase64: ""
    privateKeyValueBase64: ""
    existingSecret:
      name: ""
      certKey: ""
      keyKey: ""
gateway:
  tlsCertificates:
    customSSLCerts:
      enabled: false
      certificateValueBase64: ""
      privateKeyValueBase64: ""
    managedCerts:
      enabled: false
      name: ""
ingress:
  tls: false
  tlsCertificates:
    existingSecret:
      name: ""
      certKey: ""
      keyKey: ""

Each component has their own TLS and certificate configurations and the .Values.tlsCerts key will be deleted

Ingress

From now on, the ingress resources are not inside the router component, they are below the key .Values.ingress, including the TLS option and certificate secret reference

If a customer that has now the Carto Platform deployed with ingress wants to use it also with Replicated, they must follow these steps:

  • Select Custom Access Mode
  • Select "Terminate TLS in a higher layer and connect to Carto over HTTP"
  • Add this config inside Custom Configuration:
ingress:
  enabled: true
  tls: true
  existingSecret:
    name: <domain tls secret reference> # It must exist in the namespace
router:
  service:
    type: NodePort
    annotations:
      cloud.google.com/neg: '{"ingress": true}'
extraDeploy:
  - |
    ## FrontendConfig object is used to configure downstream Ingress features
    ## Redirect port 80 to 443 automatically
    ## https://cloud.google.com/kubernetes-engine/docs/how-to/ingress-features#https_redirect
    apiVersion: networking.gke.io/v1beta1
    kind: FrontendConfig
    metadata:
      name: carto-ingress-frontend-config
      labels: {{- include "common.labels.standard" . | nindent 4 }}
        app.kubernetes.io/component: carto
        {{- if .Values.commonLabels }}
        {{- include "common.tplvalues.render" ( dict "value" .Values.commonLabels "context" $ ) | nindent 4 }}
        {{- end }}
      annotations:
        {{- if .Values.commonAnnotations }}
        {{- include "common.tplvalues.render" ( dict "value" .Values.commonAnnotations "context" $ ) | nindent 4 }}
        {{- end }}
      namespace: {{ .Release.Namespace | quote }}
    spec:
      redirectToHttps:
        enabled: true
      ## Attach a SSL Policy
      # sslPolicy: my-ssl-policy

@alvarorm22
Copy link
Contributor Author

@alvarorm22 alvarorm22 changed the title breaking change: update tlsCerts values and remove ingress resources breaking change: update tlsCerts values and ingress resources Jun 4, 2024
@alvarorm22 alvarorm22 marked this pull request as ready for review June 4, 2024 12:47
@alvarorm22 alvarorm22 changed the title breaking change: update tlsCerts values and ingress resources breaking change: update .Values.tlsCerts and ingress resources Jun 4, 2024
@alvarorm22 alvarorm22 requested a review from moicalcob June 5, 2024 09:13
@moicalcob moicalcob marked this pull request as draft October 31, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants