-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking change: update .Values.tlsCerts and ingress resources #544
Draft
alvarorm22
wants to merge
11
commits into
main
Choose a base branch
from
check-tlsCerts-values-helm-chart-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarorm22
changed the title
breaking change: update tlsCerts values and remove ingress resources
breaking change: update tlsCerts values and ingress resources
Jun 4, 2024
alvarorm22
changed the title
breaking change: update tlsCerts values and ingress resources
breaking change: update .Values.tlsCerts and ingress resources
Jun 4, 2024
moicalcob
reviewed
Jun 4, 2024
moicalcob
reviewed
Jun 4, 2024
…check-tlsCerts-values-helm-chart-options
…check-tlsCerts-values-helm-chart-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
TLS Certificates
With these changes, we are going from
to:
Each component has their own TLS and certificate configurations and the
.Values.tlsCerts
key will be deletedIngress
From now on, the ingress resources are not inside the router component, they are below the key
.Values.ingress
, including the TLS option and certificate secret referenceIf a customer that has now the Carto Platform deployed with ingress wants to use it also with Replicated, they must follow these steps: