[327482] carto-selfhosted-helm fix download customer package not working when using custom buckets #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
ghost
self-assigned this
|
This pull request has been linked to Shortcut Story #327482: Selfhosted download customer package not working when using custom buckets. |
ghost
changed the title
ghost
mentioned this pull request
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alvarorm22
approved these changes
Jul 28, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcut
Description of the change
Changes to
carto-download-customer-package.shwhen using custom buckets:docker&k8s: setsCLIENT_STORAGE_BUCKETvalue based onSELFHOSTED_GCP_PROJECT_IDfromcustomer.envfile ascarto-values.yamlsettings might be overwritten by customer-providedcustomization.yamlvalues.Applicable issues