Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where ritual/concentration string was not added to cantrips #116

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Carifio24
Copy link
Owner

This PR resolves #115 by updating the binding adapter that's used in the spell table row. This also does a bit of refactoring and makes sure that we use string resources for ritual/concentration. This doesn't really matter right now since there's not really a difference between English and Portuguese, but it might for a future translation.

@Carifio24 Carifio24 added bug Something isn't working UI Related to the app's user interface labels Dec 16, 2024
@Carifio24 Carifio24 merged commit d8a255d into master Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI Related to the app's user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cantrips don't display concentration in table
1 participant