Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hide duplicates respect spell list options and fix sort/filter binding bug #102

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

Carifio24
Copy link
Owner

@Carifio24 Carifio24 commented Oct 2, 2024

This PR fixes a similar issue as #100, but this time for the spell lists instead.

Additionally, this PR (kinda hackily, for now) fixes an issue where the sort/filter fragment layout binding could be accidentally set to null due to lifecycle events firing in an order that I didn't anticipate.

@Carifio24 Carifio24 changed the title Make hide duplicates respect spell list options Make hide duplicates respect spell list options and fix sort/filter binding bug Oct 2, 2024
@Carifio24 Carifio24 merged commit 107ece1 into master Oct 2, 2024
2 checks passed
@Carifio24 Carifio24 added the bug Something isn't working label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant