Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setup scripts. #37

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Improve setup scripts. #37

merged 6 commits into from
Oct 5, 2023

Conversation

deuszx
Copy link
Collaborator

@deuszx deuszx commented Oct 4, 2023

  1. Increases token amounts
  2. Rename Astar-specific tokens to more "random".
  3. Separate pair creation from example_setup.ts into two scripts - first one creates PSP22 tokens and the second seeds DEX (and creates token pairs if run for the first time).

@deuszx deuszx requested a review from jalooc October 4, 2023 15:36
Copy link
Contributor

@jalooc jalooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate pair creation from example_setup.ts into two scripts - first one creates PSP22 tokens and the second seeds DEX (and creates token pairs if run for the first time).

I think the scripts need renaming then - example:local and liquidity:local don't depict the difference described above. Also, there's nothing local about them, I think? The localness is determined by the WS address which can be any adress, no? (of course it won't work on any adress other than local, but then still it's not the attribute of the scripts themselves).

Comment on lines +10 to +11
// Create a new instance of contract
const wsProvider = new WsProvider(process.env.WS_NODE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is not relevant, as the line merely connects to ws.

@deuszx
Copy link
Collaborator Author

deuszx commented Oct 4, 2023

Separate pair creation from example_setup.ts into two scripts - first one creates PSP22 tokens and the second seeds DEX (and creates token pairs if run for the first time).

I think the scripts need renaming then - example:local and liquidity:local don't depict the difference described above.

OK, fair. I'll rename. Any ideas? I wanted to keep it single-word.

Also, there's nothing local about them, I think? The localness is determined by the WS address which can be any adress, no? (of course it won't work on any adress other than local, but then still it's not the attribute of the scripts themselves).

localness is determined by the env vars that are sourced in these commands (see package.json) so I think it makes sense to name them such. Especially that I'll have another PR coming that will be introducing example:common-featnet and it will source a different env file.

@jalooc
Copy link
Contributor

jalooc commented Oct 4, 2023

Ok makes sense indeed.

As to the names: idk really, I'm not the subject matter expert, but rough ideas are just what you explained in the description: createTokens.ts and addLiquidity.ts?

jalooc
jalooc previously approved these changes Oct 4, 2023
jalooc
jalooc previously approved these changes Oct 4, 2023
package.json Outdated Show resolved Hide resolved
@deuszx deuszx merged commit 6ff0082 into main Oct 5, 2023
1 check passed
@deuszx deuszx deleted the fix-consts branch October 5, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants