-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve setup scripts. #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate pair creation from example_setup.ts into two scripts - first one creates PSP22 tokens and the second seeds DEX (and creates token pairs if run for the first time).
I think the scripts need renaming then - example:local
and liquidity:local
don't depict the difference described above. Also, there's nothing local about them, I think? The localness is determined by the WS address which can be any adress, no? (of course it won't work on any adress other than local, but then still it's not the attribute of the scripts themselves).
// Create a new instance of contract | ||
const wsProvider = new WsProvider(process.env.WS_NODE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is not relevant, as the line merely connects to ws.
OK, fair. I'll rename. Any ideas? I wanted to keep it single-word.
localness is determined by the env vars that are sourced in these commands (see |
Ok makes sense indeed. As to the names: idk really, I'm not the subject matter expert, but rough ideas are just what you explained in the description: |
Co-authored-by: Piotr <[email protected]>
example_setup.ts
into two scripts - first one creates PSP22 tokens and the second seeds DEX (and creates token pairs if run for the first time).